Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix classifier dropped in artifact pom.xml #32100

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Aug 7, 2024

Fix #31634

Reverted https://github.com/apache/beam/pull/28756/files#diff-0435a83a413ec063bf7e682cadcd56776cd18fc878f197cc99a65fc231ef2047L1918-L1919

This was indeed introduced in #28756. Task.classifier was removed in Gradle8 to arChiveClassifier, however, ProjectDependency still has classifier field.

Tested with ./gradlew :sdks:java:io:clickhouse:publishToMavenLocal -Ppublishing and inspected the generated pom has

<dependency>
      <groupId>com.clickhouse</groupId>
      <artifactId>clickhouse-jdbc</artifactId>
      <version>0.3.2-patch10</version>
      <scope>compile</scope>
      <classifier>all</classifier>

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Aug 7, 2024
@Abacn
Copy link
Contributor Author

Abacn commented Aug 7, 2024

R: @BentsiLeviav @damccorm

For now, user can add

implementation "com.clickhouse:clickhouse-jdbc:0.3.2-patch10:all"

in their project to mitigate

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 1f09065 into apache:master Aug 8, 2024
21 checks passed
@Abacn Abacn deleted the fixclassfier branch August 8, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ClickHouseIO - wrong JDBC dependency import
2 participants